feat(prometheus): add ContextLabels to ClientMetrics - #798
Merged
Conversation
johanbrandhorst
approved these changes
Sep 5, 2025
johanbrandhorst
left a comment
Collaborator
There was a problem hiding this comment.
This looks great, thank you! I'm not sure about the test failure, that doesn't look like it has anything to do with this PR, does it fail locally for you too?
Contributor
Author
Collaborator
|
Good enough for me, it looks like a flaky test |
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This PR implements #783 and adds methods for adding labels from context.
Changes
WithClientContextLabelsoption toClientMetrics, similarWithContextLabelsclientMetricsConfigto retain the ability to pass optionsWithContextLabels,WithClientHandlingTimeHistogram,WithClientStreamRecvHistogram,WithClientStreamSendHistogramin any order. Histograms that are created in options must receive label names that are also created in options.Verification
WithLabelsFromContext