avoid unnecessary logging field creation when payload logging is disabled - #809
Merged
Conversation
johanbrandhorst
approved these changes
Nov 1, 2025
johanbrandhorst
left a comment
johanbrandhorst
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, makes sense!
Contributor
Author
|
Tanks for merging! I noticed that the latest release tag hasn’t been updated in quite a while. Could you create a new tag? |
Collaborator
|
Sure, done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While debugging a performance-critical gRPC stream, I noticed that the logging reporter creates logging fields for every sent and received message, even when the
LoggableEventoptionsPayloadReceivedandPayloadSentare not set.This unnecessary field creation increases garbage collection pressure and negatively impacts throughput.
Changes
Added an early return in the
PostMsgSend()andPostMsgReceive()to skip building logging fields when payload logging is disabled.Verification
Verified with existing unit tests.