Skip to content

refactor(aws-lambada): remove FIXME in @ts-expect-error - #5130

Merged
yusukebe merged 1 commit into
mainfrom
refactor/aws-lambda-remove-fixme
Jul 17, 2026
Merged

refactor(aws-lambada): remove FIXME in @ts-expect-error#5130
yusukebe merged 1 commit into
mainfrom
refactor/aws-lambda-remove-fixme

Conversation

@yusukebe

@yusukebe yusukebe commented Jul 17, 2026

Copy link
Copy Markdown
Member

@ts-expect-error is not bad. We don't have to "fix it"; if so, the type definition, which does not affect users, will be fat.

Closes #5123

The author should do the following, if applicable

  • Add tests
  • Run tests
  • bun run format:fix && bun run lint:fix to format the code
  • Add TSDoc/JSDoc to document the code
@github-actions

Copy link
Copy Markdown

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 35,991.99 50,665.16 31,735.12 25,575.70
hono (current) bun 36,513.67 51,643.27 32,301.28 25,596.47
Change +1.45% +1.93% +1.78% +0.08%
@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.08%. Comparing base (c285f9a) to head (027fb15).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5130   +/-   ##
=======================================
  Coverage   79.08%   79.08%           
=======================================
  Files         154      154           
  Lines       10764    10764           
  Branches     2254     2254           
=======================================
  Hits         8513     8513           
  Misses       2251     2251           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@yusukebe
yusukebe merged commit 21b44b6 into main Jul 17, 2026
20 checks passed
@yusukebe
yusukebe deleted the refactor/aws-lambda-remove-fixme branch July 17, 2026 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant