fix(jsx): handle useSyncExternalStore subscription and snapshot changes - #5166
Merged
Conversation
Refresh the snapshot after attaching the new subscription so switching stores does not leave stale state behind.
Bundle size check
Compiler Diagnostics (tsc)
Compiler Diagnostics (typescript-go)
Reported by octocov |
Member
Author
|
Hi @yusukebe, |
HTTP Performance Benchmark
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5166 +/- ##
=======================================
Coverage 79.08% 79.09%
=======================================
Files 154 154
Lines 10764 10782 +18
Branches 2254 2253 -1
=======================================
+ Hits 8513 8528 +15
- Misses 2251 2254 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #5162
The reported issue can be addressed by making the subscription effect depend on
subscribe. This PR goes slightly further and also handles changes togetSnapshot:subscribechanges.getSnapshotis reflected without waiting for a store notification.subscribeandgetSnapshot.While investigating this, I also explored fixing the underlying deferred effect and cleanup behavior. Since that would affect all effect hooks and needs broader review, it is intentionally kept out of this PR; see the draft PoC in #5165.
The author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code