chore: remove undici in favor of global fetch - #5168
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5168 +/- ##
=======================================
Coverage 79.09% 79.09%
=======================================
Files 154 154
Lines 10783 10783
Branches 2253 2253
=======================================
Hits 8529 8529
Misses 2254 2254 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
yusukebe
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
undiciis only used inruntime-tests/node/index.test.tsto callfetch, which has been global since Node 18. The test stack already requires Node >= 20, so the dependency can be dropped and the test can just use the globalfetch.It still appears in
bun.lockas a transitive dep, so the version line changes there instead of going awayThe author should do the following, if applicable
bun run format:fix && bun run lint:fixto format the code