Skip to content

feat(inputs.lustre2): support reading bulk read/write stats #14813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 18, 2024
Merged

feat(inputs.lustre2): support reading bulk read/write stats #14813

merged 1 commit into from
Mar 18, 2024

Conversation

@mstrandboge
Copy link
Member

Summary

Continuation of #7733

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #13636
@mstrandboge mstrandboge self-assigned this Feb 13, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Feb 13, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@mstrandboge mstrandboge marked this pull request as ready for review March 12, 2024 18:38
@mstrandboge mstrandboge assigned powersj and srebhan and unassigned mstrandboge Mar 12, 2024
powersj
powersj reviewed Mar 13, 2024
View reviewed changes
@srebhan srebhan removed their assignment Mar 14, 2024
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 14, 2024
@powersj powersj assigned mstrandboge and srebhan and unassigned powersj and mstrandboge Mar 14, 2024
srebhan
srebhan reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DStrand1 thanks for the code, just one small question from my side...
plugins/inputs/lustre2/lustre2.go
Comment on lines +514 to +517
for _, wanted := range wantedFields {
if headerName != wanted.inProc {
continue
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't it be easier to make wantedFields a map and look-up the headerName?
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, I don't like the way this code is laid out currently with the field mappings and I plan to refactor it in a follow-up PR. For now I just followed how the other mappings were done, but I can refactor this here instead if you'd prefer
srebhan
srebhan approved these changes Mar 18, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @DStrand1!
@srebhan srebhan merged commit 0f91ca6 into influxdata:master Mar 18, 2024
@github-actions github-actions bot added this to the v1.31.0 milestone Mar 18, 2024
@lukeyeager lukeyeager mentioned this pull request Mar 21, 2024
Merged
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
@mstrandboge mstrandboge deleted the fix/13636 branch October 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

3 participants

@mstrandboge @powersj @srebhan