Skip to content

Conversation

@srebhan
Copy link
Member

@srebhan srebhan commented Mar 12, 2024

Summary

Add support for secrets to all SNMP-family plugins.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14972

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Mar 12, 2024
@srebhan srebhan marked this pull request as ready for review March 12, 2024 09:45
@srebhan srebhan added area/snmp plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/processor labels Mar 12, 2024
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 12, 2024
@KoMa1978
Copy link

KoMa1978 commented Mar 12, 2024

Hi,

it is not really working. This is my telegraf.conf with the secrets config (this one is working fine with "<< token = "@{localsecrets:influxdb_token}" >>"for influx):

[[secretstores.jose]]
  id = "localsecrets"
  path = "/etc/telegraf/secrets"
  password = "xxxx"
$ telegraf secrets list
Known secrets for store "localsecrets":
    influxdb_token                  
    snmpv3_operator_token           
    snmpv3_token              
[[inputs.snmp]]
...
  auth_protocol = "SHA"
  auth_password = "@{localsecrets:snmpv3_token}"
  priv_protocol = "AES"
  priv_password = "@{localsecrets:snmpv3_token}"
$telegraf --test --config /etc/telegraf/telegraf.d/snmp.conf.test 
2024-03-12T12:52:16Z I! Loading config: /etc/telegraf/telegraf.d/snmp.conf.test
2024-03-12T12:52:16Z E! unknown secret-store for "@{localsecrets:snmpv3_token}"
@KoMa1978
Copy link

KoMa1978 commented Mar 12, 2024

Ignore the above ...

It is working fine, I forgot to add the telegraf config (where the secretstore is defined) in the test
This one is working fine:

$telegraf --test --config /etc/telegraf/telegraf.conf --config /etc/telegraf/telegraf.d/snmp.conf.test

@powersj powersj removed their assignment Mar 12, 2024
@mstrandboge mstrandboge merged commit f674099 into influxdata:master Mar 13, 2024
@github-actions github-actions bot added this to the v1.31.0 milestone Mar 13, 2024
if !s.PrivPassword.Empty() {
p, err := s.PrivPassword.Get()
if err != nil {
return GosnmpWrapper{}, fmt.Errorf("getting private password failed: %w", err)
Copy link
Contributor

@Hipska Hipska Apr 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-				return GosnmpWrapper{}, fmt.Errorf("getting private password failed: %w", err)
+				return GosnmpWrapper{}, fmt.Errorf("getting privacy password failed: %w", err)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/snmp feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins plugin/processor ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

5 participants