Skip to content

feat(inputs.radius): Provide setting to set request IP address #14981

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Mar 12, 2024

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #14962

@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Mar 12, 2024
@powersj powersj marked this pull request as ready for review March 12, 2024 20:35
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 12, 2024
@srebhan
Copy link
Member

srebhan commented Mar 14, 2024

@powersj according to RFC2865 the field (or NAS-Identifier) MUST be present for the access-request packet we are sending. So I think we should add a nas_identifier option and use this or determine the LocalAddr of the client and use it as NAS-IP-Address...

@powersj
Copy link
Contributor Author

powersj commented Mar 14, 2024

While the RFC says that, our integration tests demonstrate that it is not required. Changing that to always be present would make this potentially a breaking change, hence why this is opt-in.

@powersj
Copy link
Contributor Author

powersj commented Mar 14, 2024

PR updated with the default set to 127.0.0.1 if empty.

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only comment would be to reference the term NAS-IP-Address or we name the option like this (as you had before :-()... Not sure which approach is better....

powersj and others added 2 commits March 14, 2024 14:09
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
@srebhan srebhan removed their assignment Mar 14, 2024
@telegraf-tiger
Copy link
Contributor

@mstrandboge mstrandboge merged commit fde7779 into influxdata:master Mar 15, 2024
@github-actions github-actions bot added this to the v1.31.0 milestone Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
3 participants