-
Notifications
You must be signed in to change notification settings - Fork 5.7k
feat(inputs.radius): Provide setting to set request IP address #14981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
While the RFC says that, our integration tests demonstrate that it is not required. Changing that to always be present would make this potentially a breaking change, hence why this is opt-in. |
PR updated with the default set to 127.0.0.1 if empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. My only comment would be to reference the term NAS-IP-Address or we name the option like this (as you had before :-()... Not sure which approach is better....
Co-authored-by: Sven Rebhan <36194019+srebhan@users.noreply.github.com>
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 🥳 This pull request decreases the Telegraf binary size by -2.88 % for linux amd64 (new size: 224.8 MB, nightly size 231.4 MB) 📦 Click here to get additional PR build artifactsArtifact URLs |
Summary
Checklist
Related issues
fixes: #14962