fix(inputs.sysstat): Prevent default sadc_interval from increasing on reload #15212
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On reload, telegraf throws away the
sysstat.Sysstat
instance it has and creates a new one; however, this plugin also relies on package-global state (thefirstTimestamp
variable), which leads to sysstat running sadc with increasingly long intervals following a reload, if the interval to use is not explicitly set viasadc_interval
. Fix this by moving thefirstTimestamp
state into the plugin struct.Checklist
Related issues
resolves #15102