Skip to content

feat(inputs.redis): Add latency percentiles metric #15293

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2024
Merged

feat(inputs.redis): Add latency percentiles metric #15293

merged 1 commit into from
May 6, 2024

Conversation

@fretb
Copy link
Contributor

@fretb fretb commented May 3, 2024 •
edited
Loading

Summary

"ALL" info contains latency percentile statistics, and these were not parsed. This creates problems in e.g. the Prometheus output.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15294
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 3, 2024

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
@fretb
Copy link
Contributor Author

fretb commented May 3, 2024

!signed-cla
@fretb fretb force-pushed the redis-latencystats branch 2 times, most recently from 567ae64 to f0dcfe6 Compare May 3, 2024 16:46
@powersj
Copy link
Contributor

powersj commented May 3, 2024

@fretb thanks for the PR! Could you update your fork and rebase on master please? It will help to resolve the conflicts and ensure the tests pass.
@fretb fretb force-pushed the redis-latencystats branch 2 times, most recently from f7b80e3 to c38f7db Compare May 3, 2024 17:29
@fretb fretb changed the title Add latency percentiles metrics to Redis input May 3, 2024
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 3, 2024
@fretb fretb force-pushed the redis-latencystats branch from c38f7db to b2a165b Compare May 3, 2024 17:32
@fretb fretb force-pushed the redis-latencystats branch from b2a165b to 5dbdda3 Compare May 3, 2024 17:38
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented May 3, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
powersj
powersj approved these changes May 3, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 3, 2024
@srebhan srebhan changed the title feat: latency percentiles metrics to Redis input May 6, 2024
@telegraf-tiger telegraf-tiger bot added area/redis plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 6, 2024
srebhan
srebhan approved these changes May 6, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission @fretb!
@srebhan srebhan merged commit 043489e into influxdata:master May 6, 2024
@github-actions github-actions bot added this to the v1.31.0 milestone May 6, 2024
@fretb fretb deleted the redis-latencystats branch May 6, 2024 10:30
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/redis feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

4 participants

@fretb @powersj @srebhan @mstrandboge