Skip to content

feat(inputs.win_wmi): Allow to invoke methods #15300

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 10, 2024
Merged

feat(inputs.win_wmi): Allow to invoke methods #15300

merged 5 commits into from
May 10, 2024

Conversation

@srebhan
Copy link
Member

@srebhan srebhan commented May 6, 2024

Summary

This PR allows to invoke WMI methods similar to the Invoke-Method command. This way it is possible to e.g. extract registry keys and create a metric from the returned value(s).

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14653
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels May 6, 2024
@srebhan srebhan mentioned this pull request May 6, 2024
Closed
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 8, 2024
@srebhan srebhan assigned powersj and mstrandboge and unassigned srebhan May 8, 2024
powersj
powersj reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That execute function is mighty... how on earth did you figure it out?

Two questions in line
srebhan and others added 2 commits May 10, 2024 11:06
@srebhan srebhan requested a review from powersj May 10, 2024 15:36
powersj
powersj approved these changes May 10, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last two commits look good, thanks!
@powersj powersj removed their assignment May 10, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -1.18 % for linux amd64 (new size: 236.4 MB, nightly size 239.2 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@mstrandboge mstrandboge merged commit e7703ae into influxdata:master May 10, 2024
@github-actions github-actions bot added this to the v1.31.0 milestone May 10, 2024
@BrewTestBot BrewTestBot mentioned this pull request Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

3 participants

@srebhan @powersj @mstrandboge