Skip to content

feat(agent): Add uint support in cli test output #15433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

Hipska
Copy link
Contributor

@Hipska Hipska commented May 31, 2024

Summary

I had a long time figuring out why the inputs.snmp.field conversion option of hextoint didn't work as expected. It turned out the value I tested with appears to be larger than MaxInt64 and thus only that value was returned.

Before:

> snmp,source=172.16.43.2 hextoint=9223372036854775807i 1717158016000000000

After:

> snmp,source=172.16.43.2 hextoint=9567906204395001025u 1717158016000000000

Checklist

  • No AI generated code was used in this PR

Related issues

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label May 31, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine to enable without modifying others output. Thanks

@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label May 31, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Hipska!

@srebhan srebhan merged commit a92d443 into influxdata:master Jun 3, 2024
28 of 29 checks passed
@github-actions github-actions bot added this to the v1.31.0 milestone Jun 3, 2024
@Hipska Hipska deleted the feat/agent/test_uint branch June 3, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
4 participants