Skip to content

feat(outputs.elasticsearch): Allow custom template index settings #15471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2024
Merged

feat(outputs.elasticsearch): Allow custom template index settings #15471

merged 1 commit into from
Jun 11, 2024

Conversation

@mstrandboge
Copy link
Member

Summary

Allows users to provide custom template index settings for the Elasticsearch output plugin. Fully flexible for any allowed setting rather than only allowing specific ones.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #13053
@telegraf-tiger telegraf-tiger bot added area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Jun 6, 2024
@mstrandboge mstrandboge added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jun 6, 2024
powersj
powersj reviewed Jun 6, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, one high-level question
@srebhan srebhan removed their assignment Jun 10, 2024
powersj
powersj approved these changes Jun 10, 2024
View reviewed changes
Copy link
Contributor

@powersj powersj left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up. There are some conflicts you will need to resolve.
@powersj powersj assigned srebhan and unassigned powersj Jun 10, 2024
srebhan
srebhan reviewed Jun 10, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question @DStrand1!
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

👍 This pull request doesn't change the Telegraf binary size

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@srebhan srebhan merged commit 6eef8aa into influxdata:master Jun 11, 2024
@github-actions github-actions bot added this to the v1.32.0 milestone Jun 11, 2024
@mstrandboge mstrandboge deleted the fix/13053 branch June 11, 2024 17:23
@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/elasticsearch feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

3 participants

@mstrandboge @powersj @srebhan