Skip to content

Conversation

@mstrandboge
Copy link
Member

Summary

Implements the write-through buffer persistence strategy detailed in the spec added in #14928.

Checklist

  • No AI generated code was used in this PR

Related issues

Related to #802, #14805
Continuation of #15545
Supersedes #15221

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 25, 2024
@mstrandboge mstrandboge changed the title feat: metric disk buffer Jun 25, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, some initial comments reading through this.

@srebhan srebhan changed the title feat(agent): metric disk buffer Jul 12, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and nice work @DStrand1! I have two questions...

@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the epic work @DStrand1!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 17, 2024
@srebhan srebhan removed their assignment Jul 17, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the continued effort on this! There are areas I think we should continue to enhance, but we can do that in follow-ups before the release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

3 participants