Skip to content

feat(agent): Add metric disk buffer #15564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

mstrandboge
Copy link
Member

Summary

Implements the write-through buffer persistence strategy detailed in the spec added in #14928.

Checklist

  • No AI generated code was used in this PR

Related issues

Related to #802, #14805
Continuation of #15545
Supersedes #15221

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Jun 25, 2024
@mstrandboge mstrandboge changed the title feat: metric disk buffer Jun 25, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great, some initial comments reading through this.

@srebhan srebhan changed the title feat(agent): metric disk buffer Jul 12, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and nice work @DStrand1! I have two questions...

@telegraf-tiger
Copy link
Contributor

Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the epic work @DStrand1!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 17, 2024
@srebhan srebhan removed their assignment Jul 17, 2024
Copy link
Contributor

@powersj powersj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the continued effort on this! There are areas I think we should continue to enhance, but we can do that in follow-ups before the release.

@powersj powersj merged commit 7245ea9 into influxdata:master Jul 17, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.0 milestone Jul 17, 2024
@mstrandboge mstrandboge deleted the agent/disk-buffer branch October 11, 2024 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/agent feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
3 participants