fix(agent): Fix buffer directory config and document

[mstrandboge]

Summary

Fixes buffer directory agent level config and documents the option.

Checklist

• No AI generated code was used in this PR

Related issues

resolves #15656

[josephbrosef]

hey, i tested the new build and it doesn't seem to resolve the issue. setting buffer_strategy = "disk" and buffer_directory = "/buffer_storage" at the [agent] level does not actually change the buffer strategy. It still uses memory buffer. pretty sure config.BufferStrategy and config.BufferDirectory are always an empty string, so it will always return with a 'memory' buffer.

telegraf/models/running_output.go

Line 102 in 26df1e7

b, err := NewBuffer(config.Name, config.Alias, bufferLimit, config.BufferStrategy, config.BufferDirectory)

telegraf/models/buffer.go

Lines 52 to 64 in 26df1e7

	func NewBuffer(name string, alias string, capacity int, strategy string, path string) (Buffer, error) {
	registerGob()
	bs := NewBufferStats(name, alias, capacity)
	switch strategy {
	case "", "memory":
	return NewMemoryBuffer(capacity, bs)
	case "disk":
	return NewDiskBuffer(name, path, bs)
	}
	return nil, fmt.Errorf("invalid buffer strategy %q", strategy)
	}

Those 2 values appear to come from the OutputConfig struct (which is why i thought maybe it could be set at the Output level in the referenced bug), but i can not see how those 2 struct values are supposed to get populated with the buffer_strategy and buffer_directory from the [agent] config?

telegraf/models/running_output.go

Lines 25 to 43 in 26df1e7

	type OutputConfig struct {
	Name string
	Alias string
	ID string
	StartupErrorBehavior string
	Filter Filter
	FlushInterval time.Duration
	FlushJitter time.Duration
	MetricBufferLimit int
	MetricBatchSize int
	NameOverride string
	NamePrefix string
	NameSuffix string
	BufferStrategy string
	BufferDirectory string
	}

[srebhan]

Good job @DStrand1! Only one minor comment from my side.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

🥳 This pull request decreases the Telegraf binary size by -3.96 % for linux amd64 (new size: 252.1 MB, nightly size 262.5 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[powersj]

Thank you for the update!

[srebhan]

Thanks @DStrand1!