Skip to content

fix(inputs.diskio): Print warnings once, add details to messages #15667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 25, 2024
Merged

fix(inputs.diskio): Print warnings once, add details to messages #15667

merged 1 commit into from
Jul 25, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jul 25, 2024

Summary

These warnings are printed every time and probably should not be as it is very unlikely that something would change to make the behavior start working. Additionally, the warnings are void of actual information about what went wrong, what file was attempting to be read, etc.

Checklist

  • No AI generated code was used in this PR

Related issues

fixes: #15666
@powersj
fix(inputs.diskio): Print warnings once, add details to messages
5ab72b5 
These warnings are printed every time and probably shoud not be as it is
very unlikely that something would change to make the beahvior start
working. Additionally, the warnings are void of actual information about
what went wrong, what file was attempting to be read, etc.

fixes: influxdata#15666
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 25, 2024
@powersj powersj mentioned this pull request Jul 25, 2024
Closed
@powersj powersj self-assigned this Jul 25, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 4.12 % for linux amd64 (new size: 262.5 MB, nightly size 252.1 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 25, 2024
@powersj powersj assigned mstrandboge and srebhan and unassigned powersj Jul 25, 2024
@srebhan srebhan removed their assignment Jul 25, 2024
@mstrandboge mstrandboge merged commit 934b4a0 into influxdata:master Jul 25, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.3 milestone Jul 25, 2024
powersj added a commit that referenced this pull request Aug 12, 2024
@powersj
fix(inputs.diskio): Print warnings once, add details to messages (#15667
dde5568 
)

(cherry picked from commit 934b4a0)
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
3 participants
@powersj @srebhan @mstrandboge