Skip to content

fix(inputs.mqtt_consumer): Restore trace logging option #15670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 29, 2024
Merged

fix(inputs.mqtt_consumer): Restore trace logging option #15670

merged 1 commit into from
Jul 29, 2024

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jul 26, 2024

Summary

In #15429, I added trace logging to the mqtt outputs for v3 and v5. I removed trace logging settings from the input, moving it to the common code. However, the input does not even use the common code facepalm. This restores the trace option for the input. I discovered this while testing out the new logging mechanisms.

Checklist

  • No AI generated code was used in this PR
@powersj
fix(inputs.mqtt_consumer): Restore trace logging option
35320d0 
In influxdata#15429, I added trace logging to the mqtt outputs for v3 and v5. I
removed trace logging settings from the input, moving it to the common
code. However, the input does not even use the common code *facepalm*.
This restores the trace option for the input.
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Jul 26, 2024
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Jul 26, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

⚠️ This pull request increases the Telegraf binary size by 4.12 % for linux amd64 (new size: 262.5 MB, nightly size 252.1 MB)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@mstrandboge mstrandboge removed their assignment Jul 26, 2024
srebhan
srebhan approved these changes Jul 29, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;-)
@srebhan srebhan merged commit f9900f8 into influxdata:master Jul 29, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.31.3 milestone Jul 29, 2024
@powersj powersj mentioned this pull request Jul 31, 2024
Closed
powersj added a commit that referenced this pull request Aug 12, 2024
@powersj
fix(inputs.mqtt_consumer): Restore trace logging option (#15670)
4f8641f 
(cherry picked from commit f9900f8)
@BrewTestBot BrewTestBot mentioned this pull request Aug 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/mqtt fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
3 participants
@powersj @srebhan @mstrandboge