Skip to content

fix(inputs.kinesis_consumer): Honor the configured endpoint #15788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 29, 2024
Merged

fix(inputs.kinesis_consumer): Honor the configured endpoint #15788

merged 1 commit into from
Aug 29, 2024

Conversation

@mskonovalov
Copy link
Contributor

Summary

Passing endpoint from config to input kinesis plugin

Otherwise running locally in docker-compose it cannot connect to kinesis

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Aug 29, 2024
@mskonovalov mskonovalov mentioned this pull request Aug 29, 2024
Merged
1 task
@mskonovalov mskonovalov changed the title feat: add endpoint to input plugin as well Aug 29, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@srebhan srebhan changed the title feat: support endpoint in kinesis consumer Aug 29, 2024
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Aug 29, 2024
srebhan
srebhan approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for fixing this @mskonovalov!
@srebhan srebhan added ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. and removed feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin labels Aug 29, 2024
@mstrandboge mstrandboge merged commit de24c16 into influxdata:master Aug 29, 2024
@github-actions github-actions bot added this to the v1.32.0 milestone Aug 29, 2024
@BrewTestBot BrewTestBot mentioned this pull request Sep 9, 2024
Merged
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@mskonovalov @asaharn
fix(inputs.kinesis_consumer): Honor the configured endpoint (influxda…
51e4503 
…ta#15788)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

3 participants

@mskonovalov @srebhan @mstrandboge