Skip to content

Conversation

@srebhan
Copy link
Member

@srebhan srebhan commented Sep 10, 2024

Summary

This PR allows to use secret-store secrets for the username, password and bearer_token_string settings.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15855

@telegraf-tiger telegraf-tiger bot added area/prometheus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Sep 10, 2024
@srebhan srebhan self-assigned this Sep 11, 2024
@harsh-w
Copy link

harsh-w commented Sep 11, 2024

I can confirm that the new binary is able to read username and password from secretstore.os when using the "@{...}" notation. Greatly appreciate the fast turnaround !

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Sep 12, 2024
@srebhan srebhan assigned mstrandboge and unassigned srebhan Sep 12, 2024
@mstrandboge mstrandboge merged commit 63ac480 into influxdata:master Sep 12, 2024
@github-actions github-actions bot added this to the v1.33.0 milestone Sep 12, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/prometheus feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

4 participants