Skip to content

feat(inputs): Add option to choose the metric time source #15917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 8, 2024
Merged

feat(inputs): Add option to choose the metric time source #15917

merged 6 commits into from
Oct 8, 2024

Conversation

@LarsStegman
Copy link
Contributor

@LarsStegman LarsStegman commented Sep 20, 2024 •
edited by srebhan
Loading

Summary

Adds the option to set the timestamp to when gathering started/ended

Discussed in #15891

Checklist

  • No AI generated code was used in this PR

Related issues
@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Sep 20, 2024
@LarsStegman LarsStegman mentioned this pull request Sep 30, 2024
Merged
1 task
@srebhan
Copy link
Member

srebhan commented Oct 2, 2024

@LarsStegman there is no open issue for this I think...
srebhan
srebhan reviewed Oct 2, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good except for using a new type. Simply go with the strings please!
@srebhan srebhan changed the title feat(inputs): time source Oct 2, 2024
@srebhan srebhan self-assigned this Oct 2, 2024
@srebhan srebhan added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Oct 2, 2024
srebhan
srebhan reviewed Oct 8, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more comments on service inputs. Sorry for not catching this earlier!
srebhan
srebhan approved these changes Oct 8, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @LarsStegman!
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 8, 2024
@srebhan srebhan assigned mstrandboge and unassigned srebhan Oct 8, 2024
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 8, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@mstrandboge mstrandboge merged commit 56f2d6e into influxdata:master Oct 8, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Oct 8, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@LarsStegman @asaharn
feat(inputs): Add option to choose the metric time source (influxdata…
86495e3 
…#15917)
@LarsStegman LarsStegman deleted the feat/timesource branch March 20, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

3 participants

@LarsStegman @srebhan @mstrandboge