Skip to content

feat(inputs.snmp): Add displayhint conversion #15935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 2, 2024
Merged

feat(inputs.snmp): Add displayhint conversion #15935

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6c4785e
feat(inputs.snmp): Add displayhint conversion
Hipska Sep 24, 2024
350d999
feat(inputs.snmp): Autoselect displayhint conversion when no conversi…
Hipska Sep 25, 2024
17b482f
docs: Update option comments
Hipska Sep 25, 2024
ebb7254
feat(inputs.snmp): Deprecate redundant conversion options
Hipska Sep 25, 2024
13e0c22
test(inputs.snmp): Fix tests
Hipska Sep 25, 2024
a09c9c8
Apply review comments
Hipska Oct 2, 2024
8e6c386
chore: Add deprecation comment
Hipska Oct 2, 2024
5d9815e
Apply review comments
Hipska Oct 2, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: Add deprecation comment
  • Loading branch information
@Hipska
Hipska committed Oct 2, 2024
commit 8e6c386cacfe9b58430f09e6d1154840f487cde2
2 changes: 2 additions & 0 deletions internal/snmp/field.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -208,6 +208,7 @@ func (f *Field) Convert(ent gosnmp.SnmpPDU) (interface{}, error) {
return v, err
}

// Deprecated: Use displayhint instead
if f.Conversion == "hwaddr" {
switch vt := v.(type) {
case string:
Expand Down Expand Up @@ -308,6 +309,7 @@ func (f *Field) Convert(ent gosnmp.SnmpPDU) (interface{}, error) {
return f.translator.SnmpFormatEnum(ent.Name, ent.Value, false)
}

// Deprecated: Use displayhint instead
if f.Conversion == "enum(1)" {
return f.translator.SnmpFormatEnum(ent.Name, ent.Value, true)
}
Expand Down
Loading