Skip to content

fix(outputs.remotefile): Create a new serializer instance per output file #15968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 14, 2024
Merged

fix(outputs.remotefile): Create a new serializer instance per output file #15968

merged 4 commits into from
Oct 14, 2024

Conversation

@srebhan
Copy link
Member

@srebhan srebhan commented Oct 2, 2024 •
edited
Loading

Summary

Some serializers require a new instance per output stream such as CSV. This PR adds the framework to pass a creator function to plugins if they need it and converts the remotefile output to the new code.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15912
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Oct 2, 2024
@srebhan srebhan mentioned this pull request Oct 2, 2024
Closed
@srebhan srebhan self-assigned this Oct 2, 2024
@srebhan srebhan force-pushed the remote_file_issue_15914 branch from 564cadd to 14f38be Compare October 2, 2024 20:34
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 11, 2024
@srebhan srebhan assigned mstrandboge and unassigned srebhan Oct 11, 2024
@mstrandboge
Copy link
Member

@srebhan Could you rebase this PR?
@mstrandboge mstrandboge assigned srebhan and unassigned mstrandboge Oct 14, 2024
@srebhan srebhan force-pushed the remote_file_issue_15914 branch from 14f38be to ffd2f7d Compare October 14, 2024 18:55
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@mstrandboge mstrandboge merged commit 23fc01c into influxdata:master Oct 14, 2024
27 checks passed
@github-actions github-actions bot added this to the v1.32.2 milestone Oct 14, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@srebhan @asaharn
fix(outputs.remotefile): Create a new serializer instance per output …
6cf06f5 
…file (influxdata#15968)
srebhan added a commit that referenced this pull request Oct 28, 2024
@srebhan
fix(outputs.remotefile): Create a new serializer instance per output …
6c26ada 
…file (#15968)

(cherry picked from commit 23fc01c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

2 participants

@srebhan @mstrandboge