Skip to content

fix(agent): Fix buffer not flushing if all metrics are written #15969

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 7, 2024
Merged

fix(agent): Fix buffer not flushing if all metrics are written #15969

merged 2 commits into from
Oct 7, 2024

Conversation

@mstrandboge
Copy link
Member

Summary

Fixes an issue where the disk buffer would not always flush if the buffer was emptied entirely by a metric batch

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15868
@mstrandboge mstrandboge self-assigned this Oct 2, 2024
@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Oct 2, 2024
@mstrandboge mstrandboge mentioned this pull request Oct 2, 2024
Closed
srebhan
srebhan reviewed Oct 7, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small simplifications...
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Oct 7, 2024

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@srebhan srebhan changed the title fix(agent.buffer): Fix buffer not flushing if all metrics are written Oct 7, 2024
srebhan
srebhan approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DStrand1, please test again and merge if you are sure the changes are OK!
@srebhan srebhan added area/agent ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Oct 7, 2024
@srebhan srebhan assigned srebhan and mstrandboge and unassigned mstrandboge and srebhan Oct 7, 2024
@mstrandboge mstrandboge merged commit 7435208 into influxdata:master Oct 7, 2024
28 of 29 checks passed
@mstrandboge mstrandboge deleted the fix/15868 branch October 7, 2024 16:32
@github-actions github-actions bot added this to the v1.32.1 milestone Oct 7, 2024
srebhan pushed a commit that referenced this pull request Oct 7, 2024
@mstrandboge @srebhan
fix(agent): Fix buffer not flushing if all metrics are written (#15969)
a5aff61 
(cherry picked from commit 7435208)
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@mstrandboge @asaharn
fix(agent): Fix buffer not flushing if all metrics are written (influ…
1fc5a5f 
…xdata#15969)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/agent fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

2 participants

@mstrandboge @srebhan