Skip to content

feat(inputs.socket_listener): Use reception time as timestamp #15976

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 10, 2024
Merged

feat(inputs.socket_listener): Use reception time as timestamp #15976

merged 1 commit into from
Oct 10, 2024

Conversation

LarsStegman
Copy link
Contributor

Summary

Because #15891 causes processing to take place asynchronously, the timestamps might be late by tens of milliseconds. This PR registers the time right after the buffer is read and passes it on to the processing function.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves
@LarsStegman LarsStegman changed the title Feat/socket listener timestamping Oct 3, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 3, 2024
@LarsStegman LarsStegman force-pushed the feat/socket-listener-timestamping branch from eebe8c2 to 46a70b8 Compare October 7, 2024 11:23
@srebhan srebhan changed the title feat(inputs.socket_listener): Use buffer read time as timestamp Oct 7, 2024
srebhan
srebhan approved these changes Oct 7, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @LarsStegman!
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 7, 2024
@LarsStegman LarsStegman force-pushed the feat/socket-listener-timestamping branch from 46a70b8 to 371be5a Compare October 10, 2024 09:29
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@mstrandboge mstrandboge merged commit 4e6e2a2 into influxdata:master Oct 10, 2024
26 of 27 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Oct 10, 2024
asaharn pushed a commit to asaharn/telegraf that referenced this pull request Oct 16, 2024
@LarsStegman @asaharn
feat(inputs.socket_listener): Use reception time as timestamp (influx…
e778501 
…data#15976)
@LarsStegman LarsStegman deleted the feat/socket-listener-timestamping branch March 20, 2025 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
3 participants
@LarsStegman @srebhan @mstrandboge