Skip to content

fix(inputs.opcua): Allow to retry reads on invalid sessions #16026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 17, 2024
Merged

fix(inputs.opcua): Allow to retry reads on invalid sessions #16026

merged 2 commits into from
Oct 17, 2024

Conversation

srebhan
Copy link
Member

@srebhan srebhan commented Oct 15, 2024 •
edited
Loading

Summary

In cases where a session becomes invalid (e.g. due to the server not respecting the session timeout) we should retry the read after some time to allow the client to reactivate the session. This is done using the newly introduced read_retry_timeout and read_retry_count settings.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #15998
@telegraf-tiger telegraf-tiger bot added area/opcua fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Oct 15, 2024
@srebhan srebhan mentioned this pull request Oct 15, 2024
Closed
@srebhan srebhan self-assigned this Oct 16, 2024
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 16, 2024
@srebhan srebhan assigned mstrandboge and unassigned srebhan Oct 16, 2024
mstrandboge
mstrandboge approved these changes Oct 16, 2024
View reviewed changes
Copy link
Member

@mstrandboge mstrandboge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I'll pass it back to you since you had another question for the issue author
@mstrandboge mstrandboge assigned srebhan and unassigned mstrandboge Oct 16, 2024
@srebhan
Copy link
Member Author

srebhan commented Oct 17, 2024

Checked again and I'm sure the PR works as the reporter stated...
@srebhan srebhan merged commit 0abd184 into influxdata:master Oct 17, 2024
27 checks passed
@srebhan srebhan deleted the opcua_issue_15998 branch October 17, 2024 08:03
@github-actions github-actions bot added this to the v1.32.2 milestone Oct 17, 2024
srebhan added a commit that referenced this pull request Oct 28, 2024
@srebhan
fix(inputs.opcua): Allow to retry reads on invalid sessions (#16026)
feaa654 
(cherry picked from commit 0abd184)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/opcua fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
2 participants
@srebhan @mstrandboge