Skip to content

feat(inputs.amqp_consumer): Allow specification of queue arguments #16141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 18, 2024
Merged

feat(inputs.amqp_consumer): Allow specification of queue arguments #16141

merged 5 commits into from
Nov 18, 2024

Conversation

n1b0r
Copy link
Contributor

@n1b0r n1b0r commented Nov 5, 2024 •
edited
Loading

Summary

Allow specification of queue arguments

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16140
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Nov 5, 2024

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
@n1b0r n1b0r changed the title enable queue_arguments configuration and forward it to QueueDeclare*() Nov 5, 2024
@n1b0r n1b0r force-pushed the 16140-amqp-consumer-queue-argument branch from 61a724f to 6aaf3b6 Compare November 5, 2024 08:49
@mstrandboge mstrandboge self-assigned this Nov 5, 2024
@mstrandboge
Copy link
Member

@n1b0r Thanks for the PR! Could you sign the CLA, run make lint and also comment in your PR description that no AI generated code was used in this PR? Thanks!
@n1b0r
Copy link
Contributor Author

n1b0r commented Nov 5, 2024

!signed-cla
@n1b0r
Copy link
Contributor Author

n1b0r commented Nov 5, 2024

Hello, I signed the CLA, make lint does not change anything, and I commented the PR about AI. I am not sure why some circleci tests are failing. Should I do something about it ?
mstrandboge
mstrandboge reviewed Nov 6, 2024
View reviewed changes
@n1b0r n1b0r changed the title feat(inputs.amqp_consumer) : enable queue_arguments configuration and forward it to QueueDeclare*() Nov 7, 2024
@telegraf-tiger telegraf-tiger bot added feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 7, 2024
@mstrandboge
Copy link
Member

Could you add this field to the sample config and readme as well? Thanks!
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@mstrandboge mstrandboge assigned srebhan and unassigned mstrandboge Nov 13, 2024
@mstrandboge mstrandboge added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 13, 2024
@srebhan
Copy link
Member

srebhan commented Nov 14, 2024

@n1b0r please restore the original PR description with the checkbox! It's there for a reason...
@srebhan srebhan changed the title feat(inputs.amqp_consumer): enable queue_arguments configuration and forward it to QueueDeclare*() Nov 14, 2024
srebhan
srebhan approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your contribution @n1b0r!
@srebhan srebhan merged commit d075815 into influxdata:master Nov 18, 2024
33 checks passed
@github-actions github-actions bot added this to the v1.33.0 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
3 participants
@n1b0r @mstrandboge @srebhan