Skip to content

fix(inputs.netflow): Cast TCP ports to uint16 #16197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 18, 2024
Merged

fix(inputs.netflow): Cast TCP ports to uint16 #16197

merged 1 commit into from
Nov 18, 2024

Conversation

@joseluisgonzalezca
Copy link
Contributor

@joseluisgonzalezca joseluisgonzalezca commented Nov 18, 2024 •
edited by srebhan
Loading

Summary

This PR fixes issue #16139. TCP source port and TCP destination port of sFlow packages were not included in Telegraf metrics because their type was a complex one. By converting them to a primitive type uint16, the fields are properly included.

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #16139
@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins labels Nov 18, 2024
@joseluisgonzalezca
Copy link
Contributor Author

!signed-cla
@joseluisgonzalezca joseluisgonzalezca mentioned this pull request Nov 18, 2024
Closed
@telegraf-tiger
Copy link
Contributor

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_arm64.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz windows_i386.zip
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
@srebhan srebhan changed the title fix(inputs.netflow): cast TCP ports to uint16 Nov 18, 2024
srebhan
srebhan approved these changes Nov 18, 2024
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @joseluisgonzalezca!
@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 18, 2024
@mstrandboge mstrandboge merged commit 427b8d3 into influxdata:master Nov 18, 2024
31 checks passed
@github-actions github-actions bot added this to the v1.32.3 milestone Nov 18, 2024
@joseluisgonzalezca joseluisgonzalezca deleted the issue#16139 branch November 18, 2024 15:52
srebhan pushed a commit that referenced this pull request Nov 18, 2024
@joseluisgonzalezca @srebhan
fix(inputs.netflow): Cast TCP ports to uint16 (#16197)
a98979d 
Co-authored-by: jlgonzalez <jlgonzalez@sarenet.es>
(cherry picked from commit 427b8d3)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix pr to fix corresponding bug plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.

3 participants

@joseluisgonzalezca @srebhan @mstrandboge