feat(inputs.sqlserver): Set pool size and idle connection - #17796
Merged
skartikey merged 8 commits intoOct 20, 2025
Merged
Conversation
telegraf-tiger
Bot
added
area/sqlserver
feat
srebhan
reviewed
Oct 10, 2025
srebhan
left a comment
srebhan
left a comment
Member
There was a problem hiding this comment.
Thank you for your PR @meorkamil! A few comments from my side.
srebhan
reviewed
Oct 14, 2025
srebhan
left a comment
srebhan
left a comment
Member
There was a problem hiding this comment.
Thanks @meorkamil for the update! Some more comments...
Comment on lines
+133
to
+136
| ## Connection pool configuration. | ||
| ## Set the maximum number of open connections to the database. | ||
| ## Default is 0 (unlimited) | ||
| # max_open_connections = 0 |
Member
There was a problem hiding this comment.
Please be brief. You don't need to mention the default as this is in the commented option...
Suggested change
| ## Connection pool configuration. | |
| ## Set the maximum number of open connections to the database. | |
| ## Default is 0 (unlimited) | |
| # max_open_connections = 0 | |
| ## Maximum number of open connections to the database, 0 allows the driver to decide | |
| # max_open_connections = 0 |
Comment on lines
+138
to
+140
| ## Set the maximum number of connections in the idle connection pool. | ||
| ## Default is 2 | ||
| # max_idle_connections = 2 |
Member
There was a problem hiding this comment.
Suggested change
| ## Set the maximum number of connections in the idle connection pool. | |
| ## Default is 2 | |
| # max_idle_connections = 2 | |
| ## Maximum number of idle connections in the connection pool, 0 allows the driver to decide | |
| # max_idle_connections = 0 |
Contributor
Author
There was a problem hiding this comment.
Similar to max_open_connections, Noted.
meorkamil
force-pushed
the
feat/adding-pool-connection-inputs-sqlserver
branch
from
October 17, 2025 01:11
0f5c408 to
c081819
Compare
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
added
the
ready for final review
skartikey
reviewed
Oct 20, 2025
skartikey
left a comment
skartikey
left a comment
Contributor
There was a problem hiding this comment.
@meorkamil Thanks for the contribution!
skartikey
approved these changes
Oct 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[[inputs.sqlserver]]do not support connection pooling. Hence it created multiple connection to the database. This PR is to add the connection pool.Checklist
Related issues
resolves #17781