feat(secretstores.vault): Add plugin - #17844
Merged
skartikey merged 12 commits intoNov 28, 2025
Merged
Conversation
telegraf-tiger
Bot
added
the
feat
mstrandboge
force-pushed
the
feat/vault-secret-store
branch
from
October 17, 2025 17:39
401e9d9 to
1d8d87c
Compare
mstrandboge
marked this pull request as ready for review
October 17, 2025 17:40
Hipska
reviewed
Nov 5, 2025
mstrandboge
force-pushed
the
feat/vault-secret-store
branch
from
November 25, 2025 20:18
17f4cee to
1c9de1f
Compare
srebhan
reviewed
Nov 26, 2025
srebhan
left a comment
srebhan
left a comment
Member
There was a problem hiding this comment.
Thanks for the plugin @mstrandboge! I do have some comments and we need a bit of setting cleanup I guess...
| return resp[startIndex : endIndex+1] | ||
| } | ||
|
|
||
| func TestIntegrationKVv1(t *testing.T) { |
Member
There was a problem hiding this comment.
If looks like we can make this a table based test and merge all other tests below, can't we?
skartikey
reviewed
Nov 27, 2025
Co-authored-by: skartikey <s.kartikey@gmail.com>
skartikey
reviewed
Nov 27, 2025
skartikey
reviewed
Nov 27, 2025
Co-authored-by: skartikey <s.kartikey@gmail.com>
Co-authored-by: skartikey <s.kartikey@gmail.com>
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
srebhan
approved these changes
Nov 28, 2025
srebhan
left a comment
srebhan
left a comment
Member
There was a problem hiding this comment.
Thanks @mstrandboge and @skartikey for your contributions!
srebhan
added
the
ready for final review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a new secret store plugin for HashiCorp Vault.
Currently supports the KV v1 and v2 secret engines.
Currently supports the AppRole authentication method, including from ID, from env var, from file, and response wrapping for the secret ID.
I hope to expand support for both engines and authentication methods in the future, though I felt like this was a good starting point for the plugin.
Checklist
Related issues
resolves #17479