feat(inputs.snmp): Add option to stop polling on first error - #17948
Merged
skartikey merged 3 commits intoNov 6, 2025
Merged
Conversation
Hipska
force-pushed
the
feat/inputs/snmp/continue-on-error
branch
from
November 6, 2025 08:20
a0fc438 to
7a9eea4
Compare
srebhan
approved these changes
Nov 6, 2025
Co-authored-by: skartikey <1942366+skartikey@users.noreply.github.com>
skartikey
approved these changes
Nov 6, 2025
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When polling fails for the first table, the plugin simply continues to polling the next table, which will most likely also fail.
The addition of a new option to stop polling on such failures reduces the time this plugin takes for wrongly configured agents and the number of similar log entries.
For example, with a default configuration and a timing out agent, the time it would take to finish a gather cycle would be around: 3 * 5s * number of configured tables. Given that usual interval for snmp devices is 1m, only having 4 tables would risk the plugin missing the next gather interval.
Checklist