fix(config): Implement strict envvar handling to prevent insecure text replacement - #17966
Merged
mstrandboge merged 2 commits intoNov 15, 2025
Merged
Conversation
2 tasks
Contributor
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
skartikey
approved these changes
Nov 13, 2025
mstrandboge
approved these changes
Nov 15, 2025
|
Hi everyone! Is there any migration guide for this change? We are using environment variables both for numbers like |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement a strict version of handling environment variables which uses the capabilities of TOML parsing instead of replacing the environment variables in the raw text. This comes at a cost of only being able to use environment variables
in string settings because the initial config file must be TOML conform.
Note
The strict handling requires to opt-in using the
--strict-env-handlingcommand-line optionChecklist
Related issues