fix: gosec issue in epoch-naming - #1589
Merged
alexandear merged 1 commit intoNov 28, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a gosec (Go security linter) issue in the epoch-naming rule by adding proper error handling for the TypeCheck() method call. The fix ensures that type-checking errors are properly captured and reported, following the established error handling pattern used in other rule implementations.
Key Changes
- Added error checking for
file.Pkg.TypeCheck()with proper error reporting vialint.NewInternalFailure - Cleaned up test data by removing an invalid blank identifier short declaration and adding proper unused variable handling
- Removed the gosec exclusion for
epoch_naming.gofrom linting configuration
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rule/epoch_naming.go | Added error handling for TypeCheck() call, returning internal failure with formatted error message |
| testdata/epoch_naming.go | Removed invalid short declaration syntax with blank identifier; added _ = c to prevent unused variable warning |
| .golangci.yml | Removed gosec exclusion for epoch_naming.go now that the security issue is fixed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ccoVeille
approved these changes
Nov 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This won't cause any issues because
epoch-naminghas not been released yet.