Skip to content

fix: prefix should use stringLike when new a bucketPolicy (2) - #2124

Merged
harshavardhana merged 5 commits into
minio:masterfrom
mannreis:master
Jun 29, 2025
Merged

fix: prefix should use stringLike when new a bucketPolicy (2)#2124
harshavardhana merged 5 commits into
minio:masterfrom
mannreis:master

Conversation

@mannreis

Copy link
Copy Markdown
Contributor

Addressing minio/minio#21244

Is there a reason why #2105 was closed? Does it not fix the issue or is there more to it?

This a new attempt to fix it!

@klauspost
klauspost requested review from jiuker June 26, 2025 13:22
@jiuker

jiuker commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Stringlike used prefix to check, * will not have any difference. And mostly it's test case and some other places load this one as StringEqual, if I remember correctly.

@jiuker

jiuker commented Jun 26, 2025

Copy link
Copy Markdown
Contributor

Welcome to fix them

@mannreis

mannreis commented Jun 27, 2025

Copy link
Copy Markdown
Contributor Author

After further checking I think we need the wildcard appended to the prefix other wise it will behave as an exact match and there fore give permission denied. I found a similar example in the docs: https://min.io/docs/minio/linux/administration/identity-access-management/policy-based-access-control.html#minio-policy-variables-internal

Other wise removing the last two commits would address you suggestion.Thanks @jiuker

@harshavardhana
harshavardhana merged commit 68615a3 into minio:master Jun 29, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants