Skip to content

Conversation

@sdelamo
Copy link
Contributor

@sdelamo sdelamo commented Oct 6, 2025

Motivation and Context

For empty responses in resource completions, I am seeing such errors if values are not included:

497570535-c7c74043-55a8-473f-aafe-41beb5afe8d9

This PR adds explicitly the @JsonInclude(JsonInclude.Include.ALWAYS) annotation and a test.

How Has This Been Tested?

yes, a test is included

Breaking Changes

no.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed
Copy link
Contributor

@tzolov tzolov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sdelamo

@tzolov tzolov merged commit 83fc4f7 into modelcontextprotocol:main Oct 6, 2025
1 check passed
tzolov pushed a commit that referenced this pull request Oct 6, 2025
…letions (#601)

* define explicitely that values should always be included

* spring  apply
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants