Skip to content

Conversation

@He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Oct 31, 2025

Motivation and Context

#648

How Has This Been Tested?

Breaking Changes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update

Checklist

  • I have read the MCP Documentation
  • My code follows the repository's style guidelines
  • New and existing tests pass locally
  • I have added appropriate error handling
  • I have added or updated documentation as needed

Additional context

@He-Pin
Copy link
Contributor Author

He-Pin commented Nov 7, 2025

@tzolov wdyt about this, otherwise, we have to do a fork:(

@Kehrlann Kehrlann self-assigned this Nov 18, 2025
@Kehrlann Kehrlann force-pushed the spring5 branch 2 times, most recently from 08220b0 to a148e59 Compare November 18, 2025 13:26
@Kehrlann
Copy link
Contributor

I'm ok with this in principle, but the tests don't pass.

@Kehrlann Kehrlann added the waiting for user Waiting for user feedback or more details label Nov 18, 2025
@He-Pin
Copy link
Contributor Author

He-Pin commented Nov 18, 2025

let't me check this, thanks.

Signed-off-by: He-Pin <hepin1989@gmail.com>
.
Signed-off-by: He-Pin <hepin1989@gmail.com>
@He-Pin
Copy link
Contributor Author

He-Pin commented Nov 18, 2025

@Kehrlann I just run the test locally, it pass.
WebFluxStreamableIntegrationTests.testRootsWithMultipleHandlers

And the fails

Error has been observed at the following site(s):
	*__checkpoint ⇢ 503 SERVICE_UNAVAILABLE from DELETE http://localhost:52887/otherPath/mcp/message [DefaultWebClient]
``` should be a bug in the test suite, where, I think we should call `DELETE` on `http://localhost:52887/otherPath/mcp/` but not `http://localhost:52887/otherPath/mcp/message `
@Kehrlann Kehrlann removed the waiting for user Waiting for user feedback or more details label Nov 19, 2025
@Kehrlann Kehrlann self-requested a review November 19, 2025 09:48
@Kehrlann Kehrlann merged commit 67f8eab into modelcontextprotocol:main Nov 19, 2025
1 of 2 checks passed
@He-Pin He-Pin deleted the spring5 branch November 19, 2025 11:27
@He-Pin
Copy link
Contributor Author

He-Pin commented Nov 19, 2025

@Kehrlann Thank you very much for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants