feat: enhance error handling with custom error code preservation #653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tzolov
commented
Nov 6, 2025
tzolov
commented
- Improve McpClientSession error handling to preserve custom error codes and data from McpError instances.
- Add aggregated exception messages to error data field for better debugging.
- Include test coverage for various McpClientSession error scenarios.
- Improve McpClientSession error handling to preserve custom error codes and data from McpError instances. - Add aggregated exception messages to error data field for better debugging. - Include test coverage for various McpClientSession error scenarios. Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Kehrlann
approved these changes
Nov 6, 2025
Contributor
Kehrlann
left a comment
Kehrlann
left a comment
There was a problem hiding this comment.
A few suggestions for the tests
Comment on lines
190
to
191
| transport = new MockMcpClientTransport(); | ||
| session = new McpClientSession(TIMEOUT, transport, Map.of(testMethod, failingHandler), Map.of()); |
Contributor
There was a problem hiding this comment.
Use the transport from the class, and make a new session instance.
Suggested change
| transport = new MockMcpClientTransport(); | |
| session = new McpClientSession(TIMEOUT, transport, Map.of(testMethod, failingHandler), Map.of()); | |
| var session = new McpClientSession(TIMEOUT, transport, Map.of(testMethod, failingHandler), Map.of()); |
Goes for all tests.
Comment on lines
272
to
273
| @Test | ||
| void testRequestHandlerThrowsMcpErrorWithoutJsonRpcError() { |
Contributor
There was a problem hiding this comment.
[suggesting] remove this tests
Comment on lines
303
to
304
| @Test | ||
| void testRequestHandlerThrowsResourceNotFoundError() { |
Contributor
There was a problem hiding this comment.
[suggestion] remove this test, it's a special case of testRequestHandlerThrowsMcpErrorWithJsonRpcError
Signed-off-by: Christian Tzolov <christian.tzolov@broadcom.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.