fix: Use FileUrl on the resources/list call in the simple-resource example
#907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nandsha
force-pushed
the
fix/simple-resource-url-validation
branch
from
235ca53 to
6c05a27
Compare
nandsha
force-pushed
the
fix/simple-resource-url-validation
branch
from
6ae96b4 to
9f68c6a
Compare
Use FileUrl for clean file:// URL construction with proper function signature. Fixes modelcontextprotocol#892
nandsha
force-pushed
the
fix/simple-resource-url-validation
branch
from
9f68c6a to
03b762e
Compare
Kludex
approved these changes
Jun 11, 2025
Member
|
We should be testing the examples cc @ihrpr |
nandsha
changed the title
FileUrl on the resources/list call in the simple-resource example
saqadri
pushed a commit
to saqadri/stdio-fixes
that referenced
this pull request
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
AnyUrl(f"file:///{name}.txt")fails validation because it requires hosts, but file URLs don't have them.Solution
Before:
After
Use
FileUrlfor cleanfile://URL construction with correct function signature.Testing
✅ Server works with MCP Inspector
✅ Resources list and read correctly
✅ Pyright passes with 0 errors
✅ All format and lint checks pass
Fixes #892