[v14.x] build: pin Windows GitHub runner to windows-2019#42350
Closed
richardlau wants to merge 2 commits intonodejs:v14.x-stagingfrom
Closed
[v14.x] build: pin Windows GitHub runner to windows-2019#42350richardlau wants to merge 2 commits intonodejs:v14.x-stagingfrom
richardlau wants to merge 2 commits intonodejs:v14.x-stagingfrom
Conversation
Adds Bryan English and his public key to the README for releases. PR-URL: nodejs#42102 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Danielle Adams <adamzdanielle@gmail.com>
Node.js 14 currently doesn't support building with Visual Studio 2022. For now, pin the Windows workflow to run on `windows-2019` instead of `windows-latest`.
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
lpinca
approved these changes
Mar 15, 2022
richardlau
added
the
fast-track
Contributor
|
Fast-track has been requested by @richardlau. Please 👍 to approve. |
tniessen
approved these changes
Mar 15, 2022
aduh95
approved these changes
Mar 15, 2022
richardlau
added a commit
that referenced
this pull request
Mar 15, 2022
Node.js 14 currently doesn't support building with Visual Studio 2022. For now, pin the Windows workflow to run on `windows-2019` instead of `windows-latest`. PR-URL: #42350 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
richardlau
force-pushed
the
v14.x-staging
branch
from
390c6b8 to
35c6842
Compare
Member
Author
|
Landed in b5c52e3. |
This was referenced Mar 17, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node.js 14 currently doesn't support building with Visual Studio 2022.
For now, pin the Windows workflow to run on
windows-2019instead ofwindows-latest.Refs: #42347 (comment)