Skip to content

doc: remove optional title prefixes#60087

Merged
nodejs-github-bot merged 2 commits intonodejs:mainfrom
avivkeller:companion-stricter-regexps
Oct 5, 2025
Merged

doc: remove optional title prefixes#60087
nodejs-github-bot merged 2 commits intonodejs:mainfrom
avivkeller:companion-stricter-regexps

Conversation

@avivkeller
Copy link
Member

Ref: nodejs/doc-kit#378
Companion: nodejs/doc-kit#449

Removes 3 outlier titles, so that stricter RegExps can be used in doc-kit.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Oct 1, 2025
@addaleax addaleax added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 2, 2025
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 3, 2025
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/60087
✔  Done loading data for nodejs/node/pull/60087
----------------------------------- PR info ------------------------------------
Title      doc: remove optional title prefixes (#60087)
Author     Aviv Keller <me@aviv.sh> (@avivkeller)
Branch     avivkeller:companion-stricter-regexps -> nodejs:main
Labels     doc
Commits    2
 - doc: remove optional title prefixes
 - fixup!
Committers 1
 - avivkeller <me@aviv.sh>
PR-URL: https://github.com/nodejs/node/pull/60087
Refs: https://github.com/nodejs/doc-kit/issues/378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/60087
Refs: https://github.com/nodejs/doc-kit/issues/378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 01 Oct 2025 16:37:54 GMT
   ✔  Approvals: 4
   ✔  - Colin Ihrig (@cjihrig): https://github.com/nodejs/node/pull/60087#pullrequestreview-3290133038
   ✔  - Yagiz Nizipli (@anonrig) (TSC): https://github.com/nodejs/node/pull/60087#pullrequestreview-3294830863
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/60087#pullrequestreview-3296262624
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/60087#pullrequestreview-3296690196
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/main up to date...
From https://github.com/nodejs/node
 * branch                  main       -> FETCH_HEAD
✔  origin/main is now up-to-date
- Downloading patch for 60087
From https://github.com/nodejs/node
 * branch                  refs/pull/60087/merge -> FETCH_HEAD
✔  Fetched commits as 79f199953177..a1754942fb82
--------------------------------------------------------------------------------
Auto-merging doc/api/util.md
[main 34e6892d93] doc: remove optional title prefixes
 Author: avivkeller <me@aviv.sh>
 Date: Wed Oct 1 12:34:53 2025 -0400
 2 files changed, 3 insertions(+), 3 deletions(-)
[main f90689a9a2] fixup!
 Author: avivkeller <me@aviv.sh>
 Date: Wed Oct 1 12:40:29 2025 -0400
 1 file changed, 1 insertion(+), 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
doc: remove optional title prefixes

PR-URL: #60087
Refs: nodejs/doc-kit#378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

[detached HEAD 724a318c3d] doc: remove optional title prefixes
Author: avivkeller <me@aviv.sh>
Date: Wed Oct 1 12:34:53 2025 -0400
2 files changed, 3 insertions(+), 3 deletions(-)
Rebasing (3/4)
Rebasing (4/4)
Executing: git node land --amend --yes
--------------------------------- New Message ----------------------------------
fixup!

PR-URL: #60087
Refs: nodejs/doc-kit#378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

[detached HEAD 652bd8c6ec] fixup!
Author: avivkeller <me@aviv.sh>
Date: Wed Oct 1 12:40:29 2025 -0400
1 file changed, 1 insertion(+), 1 deletion(-)
Successfully rebased and updated refs/heads/main.

ℹ Add commit-queue-squash label to land the PR as one commit, or commit-queue-rebase to land as separate commits.

https://github.com/nodejs/node/actions/runs/18228246317

@avivkeller
Copy link
Member Author

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Oct 5, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 5, 2025
@nodejs-github-bot nodejs-github-bot merged commit 0e942cc into nodejs:main Oct 5, 2025
30 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 0e942cc

targos pushed a commit that referenced this pull request Oct 6, 2025
PR-URL: #60087
Refs: nodejs/doc-kit#378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request Oct 11, 2025
PR-URL: #60087
Refs: nodejs/doc-kit#378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
aduh95 pushed a commit that referenced this pull request Oct 11, 2025
PR-URL: #60087
Refs: nodejs/doc-kit#378
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. doc Issues and PRs related to the documentations.

6 participants