support stdlib request.GetBody on metrics - #7931
Merged
dmathieu merged 7 commits intoMar 3, 2026
Merged
Conversation
marifari-hue
marked this pull request as ready for review
February 20, 2026 09:10
marifari-hue
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
February 20, 2026 09:10
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7931 +/- ##
=====================================
Coverage 81.7% 81.7%
=====================================
Files 304 304
Lines 23337 23342 +5
=====================================
+ Hits 19081 19091 +10
+ Misses 3867 3863 -4
+ Partials 389 388 -1
🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Feb 20, 2026
dashpole
approved these changes
Feb 20, 2026
Contributor
Author
|
Anything else I need to do to get this through :)? |
dmathieu
reviewed
Mar 3, 2026
dmathieu
reviewed
Mar 3, 2026
pellared
added a commit
that referenced
this pull request
Mar 6, 2026
### Added - Add `go.opentelemetry.io/otel/semconv/v1.40.0` package. The package contains semantic conventions from the `v1.40.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.40.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.39.0`. (#7985) - Add `Err` and `SetErr` on `Record` in `go.opentelemetry.io/otel/log` to attach an error and set record exception attributes in `go.opentelemetry.io/otel/log/sdk`. (#7924) ### Changed - `TracerProvider.ForceFlush` in `go.opentelemetry.io/otel/sdk/trace` joins errors together and continues iteration through SpanProcessors as opposed to returning the first encountered error without attempting exports on subsequent SpanProcessors. (#7856) ### Fixed - Fix missing `request.GetBody` in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp` to correctly handle HTTP2 GOAWAY frame. (#7931) - Fix semconv v1.39.0 generated metric helpers skipping required attributes when extra attributes were empty. (#7964) - Preserve W3C TraceFlags bitmask (including the random Trace ID flag) during trace context extraction and injection in `go.opentelemetry.io/otel/propagation`. (#7834) ### Removed - Drop support for [Go 1.24]. (#7984)
Tpuljak
added a commit
to Tpuljak/opentelemetry-go
that referenced
this pull request
Mar 26, 2026
Based on open-telemetry#7931 Signed-off-by: Toma Puljak <toma.puljak@hotmail.com>
dmathieu
added a commit
that referenced
this pull request
Apr 1, 2026
Based on #7931 Adding another `getBody` PR to the chain 😄. This one is harder to catch if it's a problem since logs aren't being sent in case of error. --------- Signed-off-by: Toma Puljak <toma.puljak@hotmail.com> Co-authored-by: Robert Pająk <pellared@hotmail.com> Co-authored-by: Damien Mathieu <42@dmathieu.com>
1 task
This was referenced Apr 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on #7794
This solves the exact same problem but on metrics.