[chore]: enable all rules of perfsprint #5978
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5978 +/- ##
=======================================
- Coverage 84.6% 84.6% -0.1%
=======================================
Files 272 272
Lines 22897 22897
=======================================
- Hits 19391 19390 -1
- Misses 3162 3163 +1
Partials 344 344 |
mmorel-35
force-pushed
the
perfsprint/error
branch
2 times, most recently
from
29616ad to
eb05078
Compare
mmorel-35
requested review from
MrAlias,
XSAM,
dashpole,
dmathieu and
pellared
as code owners
mmorel-35
force-pushed
the
perfsprint/error
branch
from
eb05078 to
8a5fa3f
Compare
dmathieu
approved these changes
Nov 15, 2024
pellared
approved these changes
Nov 15, 2024
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
perfsprint/error
branch
from
6d942cd to
4c2d983
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
perfsprint is a linter for performance, aiming at usages of fmt.Sprintf which have faster alternatives.