Document the ordering guarantees provided by the metrics SDK - #7453
Merged
Conversation
dashpole
requested review from
MrAlias,
XSAM,
dmathieu,
flc1125 and
pellared
as code owners
October 4, 2025 03:36
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7453 +/- ##
=====================================
Coverage 85.7% 85.7%
=====================================
Files 286 286
Lines 25331 25331
=====================================
+ Hits 21728 21729 +1
+ Misses 3222 3221 -1
Partials 381 381 🚀 New features to boost your workflow:
|
dmathieu
approved these changes
Oct 6, 2025
pellared
approved these changes
Oct 6, 2025
MrAlias
reviewed
Oct 6, 2025
Co-authored-by: Tyler Yahn <MrAlias@users.noreply.github.com>
dashpole
force-pushed
the
concurrency_docs
branch
from
October 6, 2025 16:13
bb25b4d to
1c09854
Compare
MrAlias
approved these changes
Oct 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forked from this discussion here: #7443 (comment)
It seems like a good idea for us as a group to align on and document what we are comfortable with in terms of how ordered measurements are reflected in collected metric data.