Instrument the `otlploghttp` exporter by yumosx · Pull Request #7512 · open-telemetry/opentelemetry-go

yumosx · 2025-10-16T00:36:51Z

Part of Logs SDK observability - otlploghttp exporter metrics #7018

goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp
cpu: Apple M3
                                     │ result.txt  │
                                     │   sec/op    │
ExporterExportLogs/Observability-8     70.72µ ± 3%
ExporterExportLogs/NoObservability-8   68.63µ ± 3%
geomean                                69.66µ

                                     │  result.txt  │
                                     │     B/op     │
ExporterExportLogs/Observability-8     42.90Ki ± 0%
ExporterExportLogs/NoObservability-8   42.89Ki ± 0%
geomean                                42.89Ki

                                     │ result.txt │
                                     │ allocs/op  │
ExporterExportLogs/Observability-8     557.0 ± 0%
ExporterExportLogs/NoObservability-8   557.0 ± 0%
geomean                                557.0

goos: darwin
goarch: arm64
pkg: go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp
cpu: Apple M3
                                   │ before.txt  │           after.txt           │
                                   │   sec/op    │   sec/op     vs base          │
ExporterExportLogs/Observability-8   67.46µ ± 3%   68.61µ ± 3%  ~ (p=0.105 n=10)

                                   │  before.txt  │              after.txt              │
                                   │     B/op     │     B/op      vs base               │
ExporterExportLogs/Observability-8   42.88Ki ± 0%   42.90Ki ± 0%  +0.04% (p=0.033 n=10)

                                   │ before.txt │           after.txt            │
                                   │ allocs/op  │ allocs/op   vs base            │
ExporterExportLogs/Observability-8   557.0 ± 0%   557.0 ± 0%  ~ (p=1.000 n=10) ¹
¹ all samples are equal

codecov · 2025-10-16T00:38:47Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.3%. Comparing base (f7d2882) to head (f3bf6d6).

Additional details and impacted files

@@          Coverage Diff          @@
##            main   #7512   +/-   ##
=====================================
  Coverage   86.3%   86.3%           
=====================================
  Files        295     295           
  Lines      26054   26060    +6     
=====================================
+ Hits       22497   22505    +8     
+ Misses      3184    3182    -2     
  Partials     373     373

Files with missing lines	Coverage Δ
exporters/otlp/otlplog/otlploghttp/client.go	`81.9% <100.0%> (+2.0%)`	⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

flc1125

A minor optimization.

MrAlias · 2025-10-21T15:59:54Z

/easycla

## Overview ### Added - Greatly reduce the cost of recording metrics in `go.opentelemetry.io/otel/sdk/metric` using hashing for map keys. (#7175) - Add `WithInstrumentationAttributeSet` option to `go.opentelemetry.io/otel/log`, `go.opentelemetry.io/otel/metric`, and `go.opentelemetry.io/otel/trace` packages. This provides a concurrent-safe and performant alternative to `WithInstrumentationAttributes` by accepting a pre-constructed `attribute.Set`. (#7287) - Add experimental observability for the Prometheus exporter in `go.opentelemetry.io/otel/exporters/prometheus`. Check the `go.opentelemetry.io/otel/exporters/prometheus/internal/x` package documentation for more information. (#7345) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#7353) - Add temporality selector functions `DeltaTemporalitySelector`, `CumulativeTemporalitySelector`, `LowMemoryTemporalitySelector` to `go.opentelemetry.io/otel/sdk/metric`. (#7434) - Add experimental observability metrics for simple log processor in `go.opentelemetry.io/otel/sdk/log`. (#7548) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#7459) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#7486) - Add experimental observability metrics for simple span processor in `go.opentelemetry.io/otel/sdk/trace`. (#7374) - Add experimental observability metrics in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#7512) - Add experimental observability metrics for manual reader in `go.opentelemetry.io/otel/sdk/metric`. (#7524) - Add experimental observability metrics for periodic reader in `go.opentelemetry.io/otel/sdk/metric`. (#7571) - Support `OTEL_EXPORTER_OTLP_LOGS_INSECURE` and `OTEL_EXPORTER_OTLP_INSECURE` environmental variables in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#7608) - Add `Enabled` method to the `Processor` interface in `go.opentelemetry.io/otel/sdk/log`. All `Processor` implementations now include an `Enabled` method. (#7639) - The `go.opentelemetry.io/otel/semconv/v1.38.0` package. The package contains semantic conventions from the `v1.38.0` version of the OpenTelemetry Semantic Conventions. See the [migration documentation](./semconv/v1.38.0/MIGRATION.md) for information on how to upgrade from `go.opentelemetry.io/otel/semconv/v1.37.0.`(#7648) ### Changed - `Distinct` in `go.opentelemetry.io/otel/attribute` is no longer guaranteed to uniquely identify an attribute set. Collisions between `Distinct` values for different Sets are possible with extremely high cardinality (billions of series per instrument), but are highly unlikely. (#7175) - `WithInstrumentationAttributes` in `go.opentelemetry.io/otel/trace` synchronously de-duplicates the passed attributes instead of delegating it to the returned `TracerOption`. (#7266) - `WithInstrumentationAttributes` in `go.opentelemetry.io/otel/meter` synchronously de-duplicates the passed attributes instead of delegating it to the returned `MeterOption`. (#7266) - `WithInstrumentationAttributes` in `go.opentelemetry.io/otel/log` synchronously de-duplicates the passed attributes instead of delegating it to the returned `LoggerOption`. (#7266) - Rename the `OTEL_GO_X_SELF_OBSERVABILITY` environment variable to `OTEL_GO_X_OBSERVABILITY` in `go.opentelemetry.io/otel/sdk/trace`, `go.opentelemetry.io/otel/sdk/log`, and `go.opentelemetry.io/otel/exporters/stdout/stdouttrace`. (#7302) - Improve performance of histogram `Record` in `go.opentelemetry.io/otel/sdk/metric` when min and max are disabled using `NoMinMax`. (#7306) - Improve error handling for dropped data during translation by using `prometheus.NewInvalidMetric` in `go.opentelemetry.io/otel/exporters/prometheus`. ⚠️ **Breaking Change:** Previously, these cases were only logged and scrapes succeeded. Now, when translation would drop data (e.g., invalid label/value), the exporter emits a `NewInvalidMetric`, and Prometheus scrapes **fail with HTTP 500** by default. To preserve the prior behavior (scrapes succeed while errors are logged), configure your Prometheus HTTP handler with: `promhttp.HandlerOpts{ ErrorHandling: promhttp.ContinueOnError }`. (#7363) - Replace fnv hash with xxhash in `go.opentelemetry.io/otel/attribute` for better performance. (#7371) - The default `TranslationStrategy` in `go.opentelemetry.io/exporters/prometheus` is changed from `otlptranslator.NoUTF8EscapingWithSuffixes` to `otlptranslator.UnderscoreEscapingWithSuffixes`. (#7421) - Improve performance of concurrent measurements in `go.opentelemetry.io/otel/sdk/metric`. (#7427) - Include W3C TraceFlags (bits 0–7) in the OTLP `Span.Flags` field in `go.opentelemetry.io/exporters/otlp/otlptrace/otlptracehttp` and `go.opentelemetry.io/exporters/otlp/otlptrace/otlptracegrpc`. (#7438) - The `ErrorType` function in `go.opentelemetry.io/otel/semconv/v1.37.0` now handles custom error types. If an error implements an `ErrorType() string` method, the return value of that method will be used as the error type. (#7442) ### Fixed - Fix `WithInstrumentationAttributes` options in `go.opentelemetry.io/otel/trace`, `go.opentelemetry.io/otel/metric`, and `go.opentelemetry.io/otel/log` to properly merge attributes when passed multiple times instead of replacing them. Attributes with duplicate keys will use the last value passed. (#7300) - The equality of `attribute.Set` when using the `Equal` method is not affected by the user overriding the empty set pointed to by `attribute.EmptySet` in `go.opentelemetry.io/otel/attribute`. (#7357) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploggrpc`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlplog/otlploghttp`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetricgrpc`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlpmetric/otlpmetrichttp`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc`. (#7372) - Return partial OTLP export errors to the caller in `go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracehttp`. (#7372) - Fix `AddAttributes`, `SetAttributes`, `SetBody` on `Record` in `go.opentelemetry.io/otel/sdk/log` to not mutate input. (#7403) - Do not double record measurements of `RecordSet` methods in `go.opentelemetry.io/otel/semconv/v1.37.0`. (#7655) - Do not double record measurements of `RecordSet` methods in `go.opentelemetry.io/otel/semconv/v1.36.0`. (#7656) ### Removed - Drop support for [Go 1.23]. (#7274) - Remove the `FilterProcessor` interface in `go.opentelemetry.io/otel/sdk/log`. The `Enabled` method has been added to the `Processor` interface instead. All `Processor` implementations must now implement the `Enabled` method. Custom processors that do not filter records can implement `Enabled` to return `true`. (#7639)

Instrument the client

8effabc

yumosx requested review from MrAlias, XSAM, dashpole, dmathieu, flc1125 and pellared as code owners October 16, 2025 00:36

yumosx marked this pull request as draft October 16, 2025 00:36

yumosx added 5 commits October 16, 2025 14:49

add test for instrument and add benchmark for exporter export logs

7843f44

Merge remote-tracking branch 'upstream/main' into inst-otelploghttp

39aa7ac

add changelog & cleanup for test

e3ccfcd

fix the number of pr

c2362a8

fix the lint

23960a8

yumosx changed the title ~~[WIP] Instrument the otlploghttp exporter~~ Oct 17, 2025

yumosx marked this pull request as ready for review October 18, 2025 05:39

Merge remote-tracking branch 'upstream/main' into inst-otelploghttp

d52d2b8

flc1125 approved these changes Oct 20, 2025

View reviewed changes

Comment thread exporters/otlp/otlplog/otlploghttp/client_test.go Outdated

flc1125 linked an issue Oct 20, 2025 that may be closed by this pull request

Logs SDK observability - otlploghttp exporter metrics #7018

Closed

46 tasks

adjust the bench test.

f3bf6d6

MrAlias reviewed Oct 20, 2025

View reviewed changes

Comment thread CHANGELOG.md

yumosx added 2 commits October 21, 2025 23:42

Merge remote-tracking branch 'upstream/main' into inst-otelploghttp

73d76bd

revert

c140563

MrAlias approved these changes Oct 21, 2025

View reviewed changes

MrAlias merged commit eadb423 into open-telemetry:main Oct 21, 2025
31 checks passed

MrAlias added this to the v1.39.0 milestone Dec 4, 2025

MrAlias mentioned this pull request Dec 5, 2025

Release v1.39.0 #7676

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Instrument the `otlploghttp` exporter - #7512

Instrument the `otlploghttp` exporter#7512
MrAlias merged 10 commits into
open-telemetry:mainfrom
yumosx:inst-otelploghttp

yumosx commented Oct 16, 2025 •

edited

Loading

codecov Bot commented Oct 16, 2025 •

edited

Loading

flc1125 left a comment

Uh oh!

Uh oh!

MrAlias commented Oct 21, 2025

Uh oh!

Labels

3 participants

Uh oh!

Conversation

yumosx commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

codecov Bot commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

flc1125 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MrAlias commented Oct 21, 2025

Uh oh!

Labels

3 participants

yumosx commented Oct 16, 2025 •

edited

Loading

codecov Bot commented Oct 16, 2025 •

edited

Loading