Rebuild semconvkit and verifyreadmes on changes - #7995
Merged
Conversation
MrAlias
marked this pull request as ready for review
March 3, 2026 18:22
MrAlias
requested review from
XSAM,
dashpole,
dmathieu,
flc1125 and
pellared
as code owners
March 3, 2026 18:22
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the repository Makefile tool build rules so locally-built Go tools in .tools are automatically rebuilt when their inputs change, avoiding manual cleanup when iterating on tool code.
Changes:
- Rebuild tools when
internal/tools/go.sumchanges (in addition togo.mod). - Add file-based prerequisites for
semconvkitandverifyreadmesso changes under their source directories trigger rebuilds.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7995 +/- ##
=====================================
Coverage 81.6% 81.6%
=====================================
Files 304 304
Lines 23429 23429
=====================================
Hits 19136 19136
Misses 3906 3906
Partials 387 387 🚀 New features to boost your workflow:
|
pellared
reviewed
Mar 4, 2026
pellared
reviewed
Mar 4, 2026
pellared
approved these changes
Mar 5, 2026
Member
|
I am moving to the next milestone as this is very important for a new semconv release, not mandatory for OTel Go release. |
dashpole
approved these changes
Mar 11, 2026
dmathieu
approved these changes
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the tool build dependencies in
Makefileso local tools are rebuilt when their source files change, instead of requiring manual deletion from.tools.