Skip to content

Rebuild semconvkit and verifyreadmes on changes - #7995

Merged
pellared merged 8 commits into
open-telemetry:mainfrom
MrAlias:rebuild-local-tools
Mar 11, 2026
Merged

Rebuild semconvkit and verifyreadmes on changes#7995
pellared merged 8 commits into
open-telemetry:mainfrom
MrAlias:rebuild-local-tools

Conversation

@MrAlias

@MrAlias MrAlias commented Mar 3, 2026

Copy link
Copy Markdown
Contributor

This updates the tool build dependencies in Makefile so local tools are rebuilt when their source files change, instead of requiring manual deletion from .tools.

@MrAlias MrAlias added this to the v1.42.0 milestone Mar 3, 2026
@MrAlias MrAlias added pkg:tooling Related to the tooling package Skip Changelog PRs that do not require a CHANGELOG.md entry labels Mar 3, 2026
@MrAlias
MrAlias marked this pull request as ready for review March 3, 2026 18:22
Copilot AI review requested due to automatic review settings March 3, 2026 18:22

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the repository Makefile tool build rules so locally-built Go tools in .tools are automatically rebuilt when their inputs change, avoiding manual cleanup when iterating on tool code.

Changes:

  • Rebuild tools when internal/tools/go.sum changes (in addition to go.mod).
  • Add file-based prerequisites for semconvkit and verifyreadmes so changes under their source directories trigger rebuilds.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov

codecov Bot commented Mar 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.6%. Comparing base (526b68f) to head (6fd813c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main   #7995   +/-   ##
=====================================
  Coverage   81.6%   81.6%           
=====================================
  Files        304     304           
  Lines      23429   23429           
=====================================
  Hits       19136   19136           
  Misses      3906    3906           
  Partials     387     387           

see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
Comment thread Makefile Outdated
Comment thread Makefile
Comment thread Makefile
Comment thread .github/workflows/ci.yml
@pellared

pellared commented Mar 6, 2026

Copy link
Copy Markdown
Member

I am moving to the next milestone as this is very important for a new semconv release, not mandatory for OTel Go release.

@pellared pellared modified the milestones: v1.42.0, v1.43.0 Mar 6, 2026
@pellared
pellared merged commit cb0de1f into open-telemetry:main Mar 11, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pkg:tooling Related to the tooling package Skip Changelog PRs that do not require a CHANGELOG.md entry

5 participants