Avoid linear queue.size() calls in span producers by storing queue size separately#7141
Conversation
779d2c8 to
f62710d
Compare
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (71.42%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #7141 +/- ##
============================================
+ Coverage 89.85% 89.95% +0.10%
- Complexity 6610 6678 +68
============================================
Files 740 750 +10
Lines 19986 20168 +182
Branches 1964 1977 +13
============================================
+ Hits 17958 18142 +184
+ Misses 1439 1434 -5
- Partials 589 592 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
JcTools tests exist but jacoco reports are not generated |
|
hmm. This modifies a shaded-in dependency. Is it possible to have this fixed upstream, and then get it incorporated in here? I'd hate to have our version diverge from the jctool code, if at all possible. |
Could you clarify it, please?
|
sdk/trace-shaded-deps/src/main/java/io/opentelemetry/sdk/trace/internal/JcTools.java
Show resolved
Hide resolved
whoops. I was misreading. Never mind! Carry on. |
sdk/trace/src/main/java/io/opentelemetry/sdk/trace/export/BatchSpanProcessor.java
Outdated
Show resolved
Hide resolved
…hSpanProcessor.java Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
jack-berg
left a comment
There was a problem hiding this comment.
This looks good to me. Nice optimization!
Related to #7140