Run JDK HTTP sender on non-daemon threads.#7322
Merged
jack-berg merged 4 commits intoopen-telemetry:mainfrom May 15, 2025
Merged
Run JDK HTTP sender on non-daemon threads.#7322jack-berg merged 4 commits intoopen-telemetry:mainfrom
jack-berg merged 4 commits intoopen-telemetry:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7322 +/- ##
=========================================
Coverage 89.87% 89.87%
- Complexity 6898 6899 +1
=========================================
Files 786 786
Lines 20792 20793 +1
Branches 2026 2026
=========================================
+ Hits 18686 18687 +1
Misses 1465 1465
Partials 641 641 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jack-berg
reviewed
May 8, 2025
Member
jack-berg
left a comment
jack-berg
left a comment
There was a problem hiding this comment.
Just one minor comment. Thanks for the contribution!
...ers/sender/jdk/src/main/java/io/opentelemetry/exporter/sender/jdk/internal/JdkHtttpUtil.java
Outdated
Show resolved
Hide resolved
...ers/sender/jdk/src/main/java/io/opentelemetry/exporter/sender/jdk/internal/JdkHtttpUtil.java
Outdated
Show resolved
Hide resolved
SoftlySplinter
force-pushed
the
jdkhttpsender-daemon-executor
branch
from
74dc274 to
3f8f823
Compare
SoftlySplinter
force-pushed
the
jdkhttpsender-daemon-executor
branch
2 times, most recently
from
9246d65 to
868f887
Compare
* Updated the default ExecutorService on JdkHttpSender to use the DaemonThreadFactory, instead of the JDK default.
- Moved the functions in JdkHttpUtil to JdkHttpSender. - Updated test.
SoftlySplinter
force-pushed
the
jdkhttpsender-daemon-executor
branch
from
868f887 to
00e7609
Compare
jack-berg
approved these changes
May 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7321
Updated the default ExecutorService on JdkHttpSender to use the DaemonThreadFactory, instead of the JDK default.