fix: signal attribute values not working with precompile transform - #4798
Merged
Conversation
marvinhagemeister
force-pushed
the
10.x-precompile-attr
branch
from
June 11, 2025 12:02
212f817 to
c6defb4
Compare
📊 Tachometer Benchmark ResultsSummaryA summary of the benchmark results will show here once they finish. ResultsThe full results of your benchmarks will show here once they finish. |
|
Size Change: +134 B (+0.17%) Total Size: 78.8 kB
ℹ️ View Unchanged
|
JoviDeCroock
approved these changes
Jun 11, 2025
| } else if (value === true) return name; | ||
|
|
||
| return name + '="' + encodeEntities(value) + '"'; | ||
| return name + '="' + encodeEntities('' + value) + '"'; |
Member
Author
There was a problem hiding this comment.
Added the type conversion because encodeEntities expects a string, but we could also pass a number here
Merged
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.