Skip to content

feat(android): add timer_[create, delete, getoverrun, gettime, settime] - #5108

Merged
JohnTitor merged 1 commit into
rust-lang:mainfrom
nickrobinson:main
May 28, 2026
Merged

feat(android): add timer_[create, delete, getoverrun, gettime, settime]#5108
JohnTitor merged 1 commit into
rust-lang:mainfrom
nickrobinson:main

Conversation

@nickrobinson

Copy link
Copy Markdown
Contributor

Description

Add timer_create, timer_delete, timer_getoverrun, timer_gettime, and timer_settime to the Android extern block. These are standard POSIX per-process timer functions provided by Bionic but missing from the libc crate's Android bindings.

Sources

Checklist

  • Relevant tests in libc-test/semver have been updated
  • No placeholder or unstable values like *LAST or *MAX are
    included (see #3131)
  • Tested locally (cd libc-test && cargo test --target mytarget);
    especially relevant for platforms that may not be checked in CI

@rustbot label +stable-nominated

@rustbot

rustbot commented May 18, 2026

Copy link
Copy Markdown
Collaborator

Some changes occurred in an Android module

cc @maurer

@rustbot rustbot added S-waiting-on-review stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels May 18, 2026

@JohnTitor JohnTitor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, could you squash commits into one for easier backport?

View changes since this review

@rustbot

rustbot commented May 27, 2026

Copy link
Copy Markdown
Collaborator

This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.

Add timer_create, timer_delete, timer_getoverrun, timer_gettime, and
timer_settime to the Android extern block. These are standard POSIX
per-process timer functions provided by Bionic but missing from the
libc crate's Android bindings.
@nickrobinson

nickrobinson commented May 27, 2026

Copy link
Copy Markdown
Contributor Author

Looks good, could you squash commits into one for easier backport?

View changes since this review

@JohnTitor Done

@JohnTitor

Copy link
Copy Markdown
Member

Thanks!

@JohnTitor
JohnTitor added this pull request to the merge queue May 27, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks May 27, 2026
@JohnTitor
JohnTitor added this pull request to the merge queue May 28, 2026
Merged via the queue into rust-lang:main with commit 2364caf May 28, 2026
52 checks passed
@tgross35 tgross35 mentioned this pull request Jun 23, 2026
@tgross35 tgross35 added stable-applied This PR has been cherry-picked to libc's stable release branch and removed stable-nominated This PR should be considered for cherry-pick to libc's stable release branch labels Jun 23, 2026
jollaitbot pushed a commit to sailfishos-mirror/rust-libc that referenced this pull request Jun 24, 2026
Add timer_create, timer_delete, timer_getoverrun, timer_gettime, and
timer_settime to the Android extern block. These are standard POSIX
per-process timer functions provided by Bionic but missing from the
libc crate's Android bindings.

(backport <rust-lang/libc#5108>)
(cherry picked from commit 2364caf)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stable-applied This PR has been cherry-picked to libc's stable release branch

4 participants