Skip to content

Add ToInt64Slice() and ToInt64SliceE() #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 2, 2025
Merged

Add ToInt64Slice() and ToInt64SliceE() #234

merged 2 commits into from
May 2, 2025

Conversation

@arui1628
Copy link
Contributor

Add ToInt64Slice() and ToInt64SliceE()
@CLAassistant
Copy link

CLAassistant commented Feb 13, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.
sagikazarmark
sagikazarmark requested changes Apr 12, 2025
View reviewed changes
Copy link
Collaborator

@sagikazarmark sagikazarmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please rebase your PR and use the new generic functions?
@sagikazarmark sagikazarmark added this to the v1.8.0 milestone Apr 12, 2025
@sagikazarmark sagikazarmark mentioned this pull request Apr 12, 2025
Closed
@arui1628
Copy link
Contributor Author

Could you please rebase your PR and use the new generic functions?

ok
@arui1628 arui1628 requested a review from sagikazarmark April 28, 2025 08:26
@sagikazarmark
refactor: use generic toSlice for ToInt64SliceE
4f997d9 
Signed-off-by: Mark Sagi-Kazar <mark.sagikazar@gmail.com>
@sagikazarmark sagikazarmark merged commit 01004f2 into spf13:master May 2, 2025
18 checks passed
@red-hat-konflux red-hat-konflux bot mentioned this pull request Jun 11, 2025
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@arui1628 @CLAassistant @sagikazarmark