This repository was archived by the owner on Mar 23, 2026. It is now read-only.
docs(samples): add omni query on external table aws#830
Closed
pmakani wants to merge 4 commits into
Closed
Conversation
google-cla
Bot
added
the
cla: yes
lesv
reviewed
Oct 20, 2020
| String datasetName = "MY_DATASET_NAME"; | ||
| String tableName = "MY_TABLE_NAME"; | ||
| // Create a aws connection | ||
| // projects/{project_id}/locations/{location_id}/connections/{connection_id} |
lesv
approved these changes
Oct 20, 2020
lesv
left a comment
lesv
left a comment
There was a problem hiding this comment.
A few Q's, please answer / consider, otherwise LGTM
| .forEach(row -> row.forEach(val -> System.out.printf("%s,", val.toString()))); | ||
|
|
||
| System.out.println("Query on aws external permanent table performed successfully."); | ||
| } catch (BigQueryException | InterruptedException e) { |
There was a problem hiding this comment.
Great that your showing BigQueryException | InterruptedException here, but should we just propagate them, rather than catching and printing stuff?
Comment on lines
+50
to
+52
| String query = | ||
| String.format( | ||
| "SELECT * FROM s%:%s.%s WHERE name LIKE 'W%%'", projectId, datasetName, tableName); |
There was a problem hiding this comment.
Should you mention that this is searching for things starting w/ "W" here?
Contributor
|
Fixing all the issues in #835 835 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.